Merged
Conversation
Add missing local commits
boomerangPDS/src/main/java/boomerang/flowfunction/DefaultBackwardFlowFunction.java
Outdated
Show resolved
Hide resolved
boomerangScope-Opal/src/main/scala/boomerang/scope/opal/tac/OpalIfStatement.scala
Show resolved
Hide resolved
...cope-Opal/src/main/scala/boomerang/scope/opal/transformation/stack/OperandStackBuilder.scala
Show resolved
Hide resolved
...rc/main/scala/boomerang/scope/opal/transformation/transformer/NullifyFieldsTransformer.scala
Outdated
Show resolved
Hide resolved
boomerangScope-Opal/src/main/scala/boomerang/scope/opal/tac/OpalIfStatement.scala
Show resolved
Hide resolved
Hazem-Gamall
requested changes
Apr 23, 2025
Member
Hazem-Gamall
left a comment
Hazem-Gamall
left a comment
There was a problem hiding this comment.
Just not sure whether the TODOs are intentional or not
Collaborator
Author
|
I removed not needed TODOs and added a small explanation to the parts that are left open |
Hazem-Gamall
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO